#249 Theme files don't get unique names - adva cms

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, priority, updated	tickets sorted by #, priority or updated
Combine keywords for powerful searching.
Use advanced searching »

#249 √ resolved

Theme files don't get unique names

Reported by Sven Fuchs | March 10th, 2009 @ 09:55 PM

Uploading the same theme file multiple times results in multiple db records pointing to the same disk file.

Comments and changes to this ticket

Marko Seppä June 18th, 2009 @ 12:42 PM
- → State changed from “new” to “open”
Added to product backlog.
Mitch June 24th, 2009 @ 02:55 AM
Is this still an issue? I just uploaded the a-theme.zip file twice to a test app. This resulted in two db records (as evidenced by the Themes index page) and two different folders in the themes directory ("a-theme" and "a-theme-1"). Then I deleted the preview picture from "a-theme" and only the preview picture from the first DB record was gone, indicating that the two records are pointing to the two different directories. Perhaps this can be closed?
- different_folders_and_themes.png 44.4 KB
Marko Seppä July 21st, 2009 @ 03:01 PM
- → State changed from “open” to “resolved”
Hi Mitch,

the issue here is when you upload a file with same name to a theme, these files have same name and point to same location. So this bug is related to Theme::File and not to Theme.

This problem is now fixed and pushed to master: http://github.com/svenfuchs/adva_cms/commit/9426679950d4346062c30c1...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.