make theme import more robust
Reported by Marko Seppä | May 26th, 2009 @ 01:21 PM
correct paths for theme files are following:
stylesheets/
javascripts/
images/
templates/
on ticket 308 we had a case of a zip file that had one level deeper structure theme_name/stylesheets etc. This caused the paths to mess up as mentioned on a ticket.
so, when uploading a compressed archive like #308 we should still have a working theme as a result.
Comments and changes to this ticket
-
Marko Seppä June 19th, 2009 @ 10:53 AM
- → State changed from “new” to “open”
Added to product backlog as a high priority fix.
-
Mitch June 21st, 2009 @ 08:38 PM
I have made a fix for this bug here: http://github.com/mitchlloyd/adva_cms/commit/aabf5d8124b040845f068f...
I'm not sure how robust this is; it just removes the beginning of path names for imported files if they begin with something like 'themename/'. I believe this fixes the issue in the ticket, but if anyone else has ideas on how to make this even more flexible without adding much more complexity please let me know. For instance, if someone decides to name their theme 'stylesheets' that would be a problem. Also if the zip file name and the extra directory name do not match, the import won't work.
-
Marko Seppä July 15th, 2009 @ 03:27 PM
- → State changed from “open” to “resolved”
Hi Mitch,
sorry, I was working on this and did not notice your comment here.
Well, anyway this is currently fixed.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Cutting edge cms, blog, wiki, forum ... plattform.
Find the code on GitHub: adva cms
Part of the business application framework adva best.
