#160 ✓resolved
jolohaga

Image tags referring to wrong location

Reported by jolohaga | November 10th, 2008 @ 08:31 AM | in Release 0.1.1

13 files have the root path for the images indicator.gif and delete.png set to '/images/'. These images are located in '/images/adva_cms/'.

Error messages are being generated whenever any of the view helper actions in these 13 files are called. Example:

ActionController::RoutingError (No route matches "/images/indicator.gif" with {:method=>:get, :host_with_port=>"localhost:3000", :host=>"localhost", :port=>3000, :domain=>"localhost", :subdomain=>nil}):

Attached is a patch file which fixes the paths.

Comments and changes to this ticket

  • jolohaga

    jolohaga November 10th, 2008 @ 08:57 AM

    A couple more broken links were found.

  • Sven Fuchs

    Sven Fuchs November 10th, 2008 @ 09:10 AM

    Hi Jose,

    thanks for the report. The images have been moved to the adva_cms subdirectory just recently. We'll look into this.

    As you know that these are exactly 13 images ... care to send us a list of them?

    On 10.11.2008, at 08:31, Lighthouse wrote:

  • jolohaga

    jolohaga November 10th, 2008 @ 08:25 PM

    On Nov 10, 2008, at 12:10 AM, Lighthouse wrote:

    There are only three image files:

    /images/adva_cms/icons/add.png /images/adva_cms/indicator.gif /images/adva_cms/icons/delete.png

    They are referenced without the 'adva_cms' path component in the following 14 Erb files:

    engines/adva_assets/app/views/admin/assets/filter.html.erb engines/adva_assets/app/views/admin/assets/new.html.erb engines/adva_assets/app/views/admin/assets/widget/asset.html.erb engines/adva_assets/app/views/admin/assets/widget/widget.html.erb engines/adva_cms/app/views/admin/articles/index.html.erb engines/adva_cms/app/views/admin/categories/index.html.erb engines/adva_cms/app/views/widgets/admin/section_tree.html.erb engines/adva_comments/app/views/comments/form.html.erb engines/adva_forum/app/views/admin/boards/index.html.erb engines/adva_forum/app/views/posts/form.html.erb engines/adva_forum/app/views/posts/edit.html.erb engines/adva_forum/app/views/topics/edit.html.erb engines/adva_forum/app/views/topics/new.html.erb engines/adva_wiki/app/views/admin/wikipages/index.html.erb So far I haven't found any other images causing this problem. Jose

  • Sven Fuchs

    Sven Fuchs November 10th, 2008 @ 11:50 PM

    Wow. Thanks a ton, this really helps a lot!

    On 10.11.2008, at 20:25, Lighthouse wrote:

  • Sven Fuchs

    Sven Fuchs January 9th, 2009 @ 01:48 PM

    • Milestone set to Release 0.1.1
    • State changed from “new” to “open”
    • Assigned user changed from “Sven Fuchs” to “Marko Seppä”

    Marko, I believe this is mostly done, but we should double-check and finally close this ticket.

  • Marko Seppä

    Marko Seppä January 22nd, 2009 @ 02:35 PM

    • State changed from “open” to “resolved”

    Double-checked. All seems to be in order.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<p>Cutting edge cms, blog, wiki, forum ... plattform.</p>

<p>Find the code on <a href="http://github.com/svenfuchs/adva_cms/tree/master">GitHub: adva cms</a></p>

<p>Part of the business application framework <a href="http://www.advabest.org/">adva best</a>.</p>

People watching this ticket

Pages