Artweb-design adva cms

Comments and changes to this ticket

• 

  Marko Seppä June 15th, 2009 @ 10:42 AM

  • State changed from “new” to “resolved”

  Hi Nachokb,

  thanks for the pull request.

  Only place we need the hiding and showing off login / logout links (all that application.js is currently doing) is on frontend and it is loaded to there with :default block, so we do not need it on :common.

  And sorry for late answer on this.

  -- Marko

• You flagged this item as spam.
  

  Ignacio Carrera June 15th, 2009 @ 09:47 PM

  Hi Marko,
  I see that, but I didn't mean adva_cms/application.js, but application.js, which is tha main app's -- not adva's -- js file.

  By overriding the :default expansion, adva was inhibiting Rails from loading the application.js of the app the user is developing itself, disallowing her to add her own js code unless (a) she modifies the :default expansion (which shouldn't be necessary) or (b) she puts her code into adva's js (which is in vendor, perhaps gemified?)...

  I hope I explained myself better this time :D.

  P.S.: you are right, it should be in :default...

  nachokb

• 

  Marko Seppä June 16th, 2009 @ 10:33 AM

  Hi nachokb,

  okay, got it this time :)

  your commit has been merged to master, thanks!

• You flagged this item as spam.
  

  ava james March 18th, 2023 @ 03:06 PM

  Nice post thanks for sharing check this lightinthebox discount code