#312 ✓resolved
Ignacio Carrera

Main app's application.js is not being loaded...

Reported by Ignacio Carrera | June 3rd, 2009 @ 06:07 AM

Main application's application.js is not being loaded.

Referenced commit adds it to :common (feel free to ignore that if it should be in another expansion... :default perhaps?).

Commit: http://github.com/nachokb/adva_cms/commit/5bca4a05ea240f8246bac89e9... (Pull Request sent)

Comments and changes to this ticket

  • Marko Seppä

    Marko Seppä June 15th, 2009 @ 10:42 AM

    • State changed from “new” to “resolved”

    Hi Nachokb,

    thanks for the pull request.

    Only place we need the hiding and showing off login / logout links (all that application.js is currently doing) is on frontend and it is loaded to there with :default block, so we do not need it on :common.

    And sorry for late answer on this.

    -- Marko

  • Ignacio Carrera

    Ignacio Carrera June 15th, 2009 @ 09:47 PM

    Hi Marko,
    I see that, but I didn't mean adva_cms/application.js, but application.js, which is tha main app's -- not adva's -- js file.

    By overriding the :default expansion, adva was inhibiting Rails from loading the application.js of the app the user is developing itself, disallowing her to add her own js code unless (a) she modifies the :default expansion (which shouldn't be necessary) or (b) she puts her code into adva's js (which is in vendor, perhaps gemified?)...

    I hope I explained myself better this time :D.

    P.S.: you are right, it should be in :default...

    nachokb

  • Marko Seppä

    Marko Seppä June 16th, 2009 @ 10:33 AM

    Hi nachokb,

    okay, got it this time :)

    your commit has been merged to master, thanks!

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<p>Cutting edge cms, blog, wiki, forum ... plattform.</p>

<p>Find the code on <a href="http://github.com/svenfuchs/adva_cms/tree/master">GitHub: adva cms</a></p>

<p>Part of the business application framework <a href="http://www.advabest.org/">adva best</a>.</p>

Pages